Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null ptdfSum in evaluator, relative margin case #1264

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

Godelaine
Copy link
Collaborator

@Godelaine Godelaine commented Jan 24, 2025

Fix : when ptdf sum =0 with relative margin computation, getRelativeMargin returned NaN. This happened for instance when a cnec was open in the network. Now, parameter ptdf sum lower bound is added to ptdf sum, similarly to what is done in the relative margin filler.

murgeyseb and others added 3 commits January 16, 2025 16:49
Signed-off-by: Godelaine de Montmorillon <[email protected]>
Signed-off-by: Godelaine de Montmorillon <[email protected]>
@Godelaine Godelaine requested review from phiedw and murgeyseb January 24, 2025 14:05
@Godelaine Godelaine added the PR: waiting-for-review This PR is waiting to be reviewed label Jan 24, 2025
Copy link
Collaborator

@phiedw phiedw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls fill in the PR description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: waiting-for-review This PR is waiting to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants