Partial Failure and completeData

[RoxaneChen02]

Please check if the PR fulfills these requirements

• The commit message follows our guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?

Fixes #1238

What kind of change does this PR introduce?

What is the current behavior?

• systematicSensitivityResult status of the initial 2P perimeter is set to FAILURE if sensi analysis on state with applied RAs failed even if precontingency sensi are successes, which is not coherent with the behavior during the other instants.
• use completeDataWithFailingPerimeter to handle failure during 2P initial sensi

What is the new behavior (if this is a feature change)?

• systematicSensitivityResult status of the initial 2P perimeter is set to PARTIAL_FAILURE if sensi analysis status on state with applied RAs failed.
• remove completeDataWithFailingPerimeter to reuse preexisting completeData function

Does this PR introduce a breaking change or deprecate an API?

• Yes
• No

If yes, please check if the following requirements are fulfilled

• The Breaking Change or Deprecated label has been added
• The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

[pet-mit]

I'm not sure this fixes the case where N succeeds and all N-1 fail (should give partial failure, currently gives failure, because of line 84 of SystematicSensitivityResult

[RoxaneChen02]

For me this case is handled by the line 89. If N succeeds this.status is set to success after line 89 and and keeps this value even if all N-1 fail. So in the end we have anyContingencyFailure = true and nStateResult.status = SUCCESS -> this .status is set to PARTIAL_FAILURE as it should ?

[pet-mit]

For me this case is handled by the line 89. If N succeeds this.status is set to success after line 89 and and keeps this value even if all N-1 fail. So in the end we have anyContingencyFailure = true and nStateResult.status = SUCCESS -> this .status is set to PARTIAL_FAILURE as it should ?

can you try to add a unit test to test it out ?

[RoxaneChen02]

For me this case is handled by the line 89. If N succeeds this.status is set to success after line 89 and and keeps this value even if all N-1 fail. So in the end we have anyContingencyFailure = true and nStateResult.status = SUCCESS -> this .status is set to PARTIAL_FAILURE as it should ?

can you try to add a unit test to test it out ?

Case already tested in testPartialContingencyFailures() in SystematicSensitivityResultTest.

[RoxaneChen02]

I'm not sure this fixes the case where N succeeds and all N-1 fail (should give partial failure, currently gives failure, because of line 84 of SystematicSensitivityResult

I'm not sure this fixes the case where N succeeds and all N-1 fail (should give partial failure, currently gives failure, because of line 84 of SystematicSensitivityResult

done

case already tested