Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inter-Temporal Pool #1235

Merged
merged 36 commits into from
Jan 21, 2025
Merged

Inter-Temporal Pool #1235

merged 36 commits into from
Jan 21, 2025

Conversation

RoxaneChen02
Copy link
Collaborator

@RoxaneChen02 RoxaneChen02 commented Dec 12, 2024 •
edited by bqth29
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?

Creation of the helper InterTemporalPool class that allows parallel computation on temporal data. Will be usefull for topological optimization, sensitivity computation and results processing in multi-timestamps optimization.

What is the current behavior?

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)

Other information:

@RoxaneChen02 RoxaneChen02 marked this pull request as draft December 12, 2024 14:50
bqth29 and others added 7 commits December 12, 2024 17:03
@bqth29
Merge branch 'main' into features/InterTemporalSensitivity
f590971
@bqth29
more relevant tests
18eda9c 
Signed-off-by: Thomas Bouquet <[email protected]>
merge head
9118bf0 
Signed-off-by: CHEN Roxane <[email protected]>
add json for inter temporal parameter
5db3cbe 
Signed-off-by: CHEN Roxane <[email protected]>
fix conflict
2d0d2a0 
Signed-off-by: CHEN Roxane <[email protected]>
fix style
751ec91 
Signed-off-by: CHEN Roxane <[email protected]>
@bqth29
fix tests
5f81d1f 
Signed-off-by: Thomas Bouquet <[email protected]>
@bqth29 bqth29 added feature New feature or request intertemporality Encompasses the use of multi-time-steps optimization and intertemporal constraints labels Dec 13, 2024
@bqth29 bqth29 marked this pull request as ready for review December 13, 2024 09:45
@bqth29 bqth29 requested a review from Godelaine December 13, 2024 09:46
@bqth29 bqth29 mentioned this pull request Dec 13, 2024
Open
@bqth29 bqth29 added the PR: waiting-for-review This PR is waiting to be reviewed label Dec 13, 2024
Godelaine
Godelaine reviewed Dec 19, 2024
View reviewed changes
ra-optimisation/rao-api/src/main/java/com/powsybl/openrao/raoapi/InterTemporalRaoInput.java Show resolved Hide resolved
...in/java/com/powsybl/openrao/raoapi/json/extensions/JsonInterTemporalParametersExtension.java Outdated Show resolved Hide resolved
ra-optimisation/rao-api/src/test/java/com/powsybl/openrao/raoapi/InterTemporalRaoInputTest.java Show resolved Hide resolved
ra-optimisation/rao-api/src/test/resources/RaoParameters_with_InterTemporalExtension.json Outdated Show resolved Hide resolved
tests/src/test/resources/logback.xml Outdated Show resolved Hide resolved
...ava/com/powsybl/openrao/searchtreerao/castor/algorithm/InterTemporalSensitivityAnalysis.java Outdated Show resolved Hide resolved
...ava/com/powsybl/openrao/searchtreerao/castor/algorithm/InterTemporalSensitivityAnalysis.java Outdated Show resolved Hide resolved
...ava/com/powsybl/openrao/searchtreerao/castor/algorithm/InterTemporalSensitivityAnalysis.java Outdated Show resolved Hide resolved
bqth29 added 2 commits January 2, 2025 16:09
@bqth29
Merge branch 'main' into features/InterTemporalSensitivity
e2e0dd4 
# Conflicts:
#	ra-optimisation/rao-api/src/main/java/com/powsybl/openrao/raoapi/InterTemporalRaoInput.java
@bqth29
some fixes
49129bd 
Signed-off-by: Thomas Bouquet <[email protected]>
@Godelaine Godelaine added PR: waiting-for-correction This PR is waiting to be corrected by its author and removed PR: waiting-for-review This PR is waiting to be reviewed labels Jan 6, 2025
@bqth29 bqth29 mentioned this pull request Jan 6, 2025
Closed
7 tasks
bqth29 added 2 commits January 6, 2025 17:16
@bqth29
remove inter-temporal extension of parameters
d5abe3a 
Signed-off-by: Thomas Bouquet <[email protected]>
@bqth29
fix tests
2e31413 
Signed-off-by: Thomas Bouquet <[email protected]>
Godelaine
Godelaine reviewed Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@Godelaine Godelaine left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "UT" (logs only) validating that ThreadPoolExecutor works
In new PR, try substituting ThreadPoolExecutor by a specially configured ForkJoinPool

@bqth29 bqth29 changed the title Features/inter temporal sensitivity Inter-Temporal Pool Jan 20, 2025
@bqth29
Copy link
Collaborator

bqth29 commented Jan 20, 2025

As stated in #1226, there is no need to propagate sensi through time as the timestamps are only coupled by inter-temporal constraints (out of the scope of this PR). Thus, we turned this PR to a simpler one only focusing on the InterTemporalPool.

Sensitivity computations for multiple timestamps are now being dealt with in #1258.

@bqth29 bqth29 requested a review from Godelaine January 20, 2025 09:37
@Godelaine Godelaine merged commit 221acac into main Jan 21, 2025
12 checks passed
@Godelaine Godelaine deleted the features/InterTemporalSensitivity branch January 21, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phiedw phiedw phiedw left review comments

@bqth29 bqth29 bqth29 left review comments

@Godelaine Godelaine Godelaine approved these changes

Assignees
No one assigned
Labels
feature New feature or request intertemporality Encompasses the use of multi-time-steps optimization and intertemporal constraints PR: waiting-for-correction This PR is waiting to be corrected by its author
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RoxaneChen02 @bqth29 @phiedw @Godelaine