Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSA] Use GridStateAlterations mRIDs #1162

Closed
wants to merge 8 commits into from
Closed

[CSA] Use GridStateAlterations mRIDs #1162

wants to merge 8 commits into from

Conversation

bqth29
Copy link
Collaborator

@bqth29 bqth29 commented Oct 14, 2024 •
edited
Loading

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
Fixes #1147

What kind of change does this PR introduce?
Possibility to add elementary network actions with an identifier using withId in adder.
If no id provided, a default id is set using the pattern ActionClass_networkElement_setPoint

Other information:
JSON CRAC updated from version 2.5 to 2.6; now includes optional actionId field in elementary action objects.

bqth29 added 3 commits October 14, 2024 10:37
@bqth29
add elementary action id
a43ce77 
Signed-off-by: Thomas Bouquet <[email protected]>
@bqth29
elementary action id in JSON CRAC
df7b054 
Signed-off-by: Thomas Bouquet <[email protected]>
@bqth29
elementary action id in CSA CRAC
9ee5611 
Signed-off-by: Thomas Bouquet <[email protected]>
@bqth29 bqth29 changed the title [CSA] Use GridStateAlterations i [CSA] Use GridStateAlterations mRIDs Oct 14, 2024
@bqth29 bqth29 added feature New feature or request PR: waiting-for-review This PR is waiting to be reviewed swe-csa This issue or pull request addresses a feature or a bug relative to the SWE CSA process new-crac-version This pull request introduces a new version of the JSON CRAC format experiment This subject is experimental and needs to be discussed thoroughly first labels Oct 14, 2024
@bqth29
Copy link
Collaborator Author

bqth29 commented Oct 14, 2024 •
edited
Loading

One question: if the id of an elementary action is the default one, should we export it in the JSON CRAC or not?
Currently we do export it, but I think that to minimize the differences with the export of version 2.5, it could be relevant not to export it.
Maybe let's vote with 👍 or 👎

@bqth29 bqth29 requested a review from phiedw November 6, 2024 15:41
@bqth29
Copy link
Collaborator Author

bqth29 commented Jan 17, 2025

too many conflicts, start over when less PRs are being worked on at the same time

@bqth29 bqth29 closed this Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pet-mit pet-mit Awaiting requested review from pet-mit

@benrejebmoh benrejebmoh Awaiting requested review from benrejebmoh

@jipea jipea Awaiting requested review from jipea

@phiedw phiedw Awaiting requested review from phiedw

Assignees
No one assigned
Labels
experiment This subject is experimental and needs to be discussed thoroughly first feature New feature or request new-crac-version This pull request introduces a new version of the JSON CRAC format PR: waiting-for-review This PR is waiting to be reviewed swe-csa This issue or pull request addresses a feature or a bug relative to the SWE CSA process
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CSA] Use GridStateAlteration mRID as elementary network action id
2 participants
@bqth29 @phiedw