Fix flow computation of HVDC connected at only one side #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot). Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
# Conflicts: # src/test/java/com/powsybl/openloadflow/network/HvdcNetworkFactory.java
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: VIDAL Didier (Externe) <[email protected]>
vidaldid-rte
force-pushed
the
hvdc-loss-in-N
branch
from
c8c3cd2 to
78dcfe7
Compare
rosiereflo
requested changes
Jan 24, 2024
src/main/java/com/powsybl/openloadflow/network/impl/AbstractLfBus.java
Outdated
Show resolved
Hide resolved
Signed-off-by: VIDAL Didier (Externe) <[email protected]>
rosiereflo
approved these changes
Jan 25, 2024
Signed-off-by: VIDAL Didier (Externe) <[email protected]>
vidaldid-rte
changed the title
annetill
reviewed
Jan 25, 2024
src/main/java/com/powsybl/openloadflow/network/impl/AbstractLfBus.java
Outdated
Show resolved
Hide resolved
annetill
reviewed
Jan 25, 2024
annetill
reviewed
Jan 25, 2024
Signed-off-by: VIDAL Didier (Externe) <[email protected]>
Signed-off-by: VIDAL Didier (Externe) <[email protected]>
vidaldid-rte
force-pushed
the
hvdc-loss-in-N
branch
from
06495a8 to
063e0b7
Compare
…erator...) and pinpoint limitation with current implementation Signed-off-by: VIDAL Didier (Externe) <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
annetill
reviewed
Jan 26, 2024
src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisWithActionsTest.java
Outdated
Show resolved
Hide resolved
…ify test to use network monitors Signed-off-by: VIDAL Didier (Externe) <[email protected]>
Signed-off-by: VIDAL Didier (Externe) <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
…pen-loadflow into hvdc-loss-in-N
Signed-off-by: Anne Tilloy <[email protected]>
jeandemanged
requested changes
Jan 29, 2024
src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowVscTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowVscTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/powsybl/openloadflow/ac/AcLoadFlowVscTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
374
to
375
| assertTrue(pcs2 == 0 || Double.isNaN(pcs2), "HVDC Station should not generate power " + network.getHvdcConverterStation("cs2").getTerminal().getP()); | ||
| assertTrue(pcs3 == 0 || Double.isNaN(pcs3), "HVDC Station should not generate power"); |
There was a problem hiding this comment.
Note: we get 0MW for VSC and NaN for LCC, we might leave like this for now but add a comment/note here because it is not straightforward / it is inconsistent today in OLF
There was a problem hiding this comment.
Agreed, and I am not sure it is the good solution to put NaN.
src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisWithActionsTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/powsybl/openloadflow/sa/OpenSecurityAnalysisWithActionsTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
+233
to
+238
| public static boolean isIsolatedBusForHvdc(LfBus bus, GraphConnectivity<LfBus, LfBranch> connectivity) { | ||
| // used only for hvdc lines. | ||
| // this criteria can be improved later depending on use case | ||
| return connectivity.getConnectedComponent(bus).size() == 1 && bus.getLoadTargetP() == 0.0 | ||
| && bus.getGenerators().stream().noneMatch(LfGeneratorImpl.class::isInstance); | ||
| } |
|
I would rename the PR to something like |
Signed-off-by: Anne Tilloy <[email protected]>
Signed-off-by: Anne Tilloy <[email protected]>
annetill
reviewed
Jan 29, 2024
| @@ -285,7 +285,11 @@ void addLoad(Load load, LfNetworkParameters parameters) { | |||
| } | |||
|
|
|||
| void addLccConverterStation(LccConverterStation lccCs, LfNetworkParameters parameters) { | |||
| getOrCreateLfLoad(null, parameters).add(lccCs, parameters); | |||
| if (!HvdcConverterStations.isHvdcDanglingInIidm(lccCs, parameters)) { | |||
There was a problem hiding this comment.
Because of that, we end the calculation with NaN as p for the converter station for LCC only. @jeandemanged I don't like it very much...
Signed-off-by: Anne Tilloy <[email protected]>
annetill
changed the title
|
jeandemanged
approved these changes
Jan 29, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Yes : #953
This PR fixes the disconnection in situation N and completes #961
What kind of change does this PR introduce?
When one of the LfBus is missing in the LfNetwork, the HVDC status is determined by the IIDM Network.
If that bus is isolated, the HVDC does not flow any active power.
The determination is made before all LfBus are created for LCC stations - and thus contingencies that disconnect or reconnect an HDVC link with LCC station is still NOT SUPPORTED.
What is the current behavior?
Active power flows through an HVDC even if one of the stations is dandling in situation N.
What is the new behavior (if this is a feature change)?
If one of the stations of an HVDC line is dandling in situation N, no active power flows through it.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: