Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix SA reports in MT, an support operator strategies in MT #1168

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

vidaldid-rte
Copy link
Collaborator

@vidaldid-rte vidaldid-rte commented Jan 9, 2025

NOTE: currently in WIP. Would need an evolution in the report API for a cleaner code (ability to transfer a report child from one report to another, to postprocess all reports)

Please check if the PR fulfills these requirements

  • [ X ] The commit message follows our guidelines
  • [ X ] Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
Some issues are reported in #1167

What kind of change does this PR introduce?
There are some issues with Security Analysis in MT:

  • Reports contain duplicated entries for network loading and precontingency run
  • PostContingency results are split in different node (one per thread)
  • Operator Strategies are not supported (an exception is thrown because a contingency is not in the partition of a given thread)

This PR fixes those issues

What is the new behavior (if this is a feature change)?

One report node per CC that contains in order:
One instance of network loading
One instance of precontingency run
All postcontingency results for that CC

The report is the same in single thread or multithread except that the contingency order may change.

In multi-thread mode, the check to verify that an operator strategy is associated to a contingency is not performed.

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

@vidaldid-rte vidaldid-rte added the bug Something isn't working label Jan 9, 2025
…anism to address Sonar warning

Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
@vidaldid-rte vidaldid-rte changed the title Fix SA reports in MT, an support operator strategies in MT [WIP] Fix SA reports in MT, an support operator strategies in MT Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: TODO
Development

Successfully merging this pull request may close these issues.

2 participants