Fix secondary voltage control in case of generator remote voltage control #1165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geofjamg
changed the title
vidaldid-rte
reviewed
Jan 9, 2025
src/main/java/com/powsybl/openloadflow/ac/outerloop/SecondaryVoltageControlOuterLoop.java
Show resolved
Hide resolved
vidaldid-rte
reviewed
Jan 9, 2025
src/test/java/com/powsybl/openloadflow/ac/SecondaryVoltageControlTest.java
Show resolved
Hide resolved
vidaldid-rte
reviewed
Jan 9, 2025
src/main/java/com/powsybl/openloadflow/network/GeneratorVoltageControl.java
Show resolved
Hide resolved
vidaldid-rte
reviewed
Jan 9, 2025
src/main/java/com/powsybl/openloadflow/network/GeneratorVoltageControl.java
Outdated
Show resolved
Hide resolved
vidaldid-rte
approved these changes
Jan 20, 2025
jeandemanged
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Approved, however note that this is a limited review:
I am not a user of this feature. Therefore I can only assess that code/test/doc quality is good as usual, and that no side effect would occur when secondaryVoltageControl is disabled. Regarding fitness for purpose you are on your own here.
…trol Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
…e settings are modified only when the option is active Signed-off-by: Didier Vidal <[email protected]>
Signed-off-by: Didier Vidal <[email protected]>
vidaldid-rte
force-pushed
the
fix_svc_with_remote_voltage
branch
from
aed86cb to
d69c800
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Bug fix
What is the current behavior?
Secondary voltage control outer failed in case a zone has generators belonging to a shared remote control.
What is the new behavior (if this is a feature change)?
All generators of a secondary voltage control, have local voltage control.
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: