Load active power target caching #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| public void invalidateLoadTargetP() { | ||
| loadTargetP = null; | ||
| } | ||
|
|
There was a problem hiding this comment.
Shouldn't this also be called by AbstractLfBus.addLoad (or safer LfLoadImpl.add load, dangling line, converter station etc..) ?
There was a problem hiding this comment.
After discussion, ok to consider the addXXX as builfder methods that don't need to call invalidate. The NetworkCache currently only uses setTargetP for what is implemented. So lets assume for now that if Load changes are supported in the future it will ony be through setTargetP and not adding loads or line to a bus.
vidaldid-rte
approved these changes
Jan 14, 2025
Hadrien-Godard
approved these changes
Jan 14, 2025
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
Signed-off-by: Geoffroy Jamgotchian <[email protected]>
vidaldid-rte
force-pushed
the
load_target_p_caching
branch
from
3ce0729 to
1f0e537
Compare
jeandemanged
approved these changes
Jan 14, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
No
What kind of change does this PR introduce?
Perfs improvement
What is the current behavior?
When profiling a DC security analysis we get 2.8% if the time spent in calculating bus active power. Generation part is alreadu cached bu not load part.
What is the new behavior (if this is a feature change)?
After caching also the load part, we get twice faster.
After using a traditionnal loop instead of a stream, we get 0;
Does this PR introduce a breaking change or deprecate an API?
If yes, please check if the following requirements are fulfilled
What changes might users need to make in their application due to this PR? (migration steps)
Other information: