Refactor DC Outer Loops creation #1158
Conversation
Signed-off-by: vmouradian <[email protected]>
Signed-off-by: vmouradian <[email protected]>
Signed-off-by: vmouradian <[email protected]>
Signed-off-by: vmouradian <[email protected]>
vmouradian
changed the title
Signed-off-by: vmouradian <[email protected]>
|
Support of OuterLoopNames parameters for DC is in this separated PR : #1159. |
src/main/java/com/powsybl/openloadflow/dc/DcLoadFlowEngine.java
Outdated
Show resolved
Hide resolved
...main/java/com/powsybl/openloadflow/lf/outerloop/AbstractAreaInterchangeControlOuterLoop.java
Outdated
Show resolved
Hide resolved
| static List<DcOuterLoop> createDcOuterLoops(LoadFlowParameters parameters, OpenLoadFlowParameters parametersExt) { | ||
| List<DcOuterLoop> outerLoops = new ArrayList<>(); | ||
| if (parameters.isPhaseShifterRegulationOn()) { | ||
| DcIncrementalPhaseControlOuterLoop phaseShifterControlOuterLoop = new DcIncrementalPhaseControlOuterLoop(); |
There was a problem hiding this comment.
Hello, a small remark here, maybe a little bit out of the scope of this PR : when comparing with createAcOuterLoops, it shows that the parameter phaseShifterControlMode is not taken into account in DC mode. Maybe it should be mentioned in the doc (or even with a log message, because default value of this param is CONTINUOUS_WITH_DISCRETISATION and not INCREMENTAL)
There was a problem hiding this comment.
@SylvestreSakti if we want t improve the doc for phaseShifterControlMode I think this should be done in a different PR.
The doc of this paraeter could be improved in the following way I guess (just from code reading) - that are not all related to this outerloop.
- The parameter is only relevant for AC
- in Continuous mode, only the phase shifter in active power controller mode are computed through the Newton Raphson. The current limiters are controlled by an outerloop.
- In continuous mode, if the active target power taget is impossible to reach, the newton raphson will diverge. In incremental mode, the failure occurs in the incrementalPhaseControl outerloop that cannot reach a stable state. This makes it easier to troubleshoot the failure cause.
Signed-off-by: vmouradian <[email protected]>
Signed-off-by: vmouradian <[email protected]>
|
Please check if the PR fulfills these requirements
Does this PR already have an issue describing the problem?
Part of #1091 + adds consistency (imo)
What kind of change does this PR introduce?
Feature / refactor
What is the new behavior (if this is a feature change)?
DC Outerloops creation is made more consistent with AC ones (created in the OLF parameters class then are contained in DcLoadFlowParameters)
Support of
outerLoopNamesparameter for DC is in this separated PR : #1159.Does this PR introduce a breaking change or deprecate an API?