Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zoom to fit functionality and button to NAD viewer #161

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

massimo-ferraro
Copy link
Contributor

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Does this PR already have an issue describing the problem?
no

What kind of change does this PR introduce?
feature

Does this PR introduce a new Powsybl Action implying to be implemented in simulators or pypowsybl?

  • Yes, the corresponding issue is here
  • No

What is the current behavior?
In network area diagram viewer there is no functionality to automatically resize the SVG in order to fit it in the window

What is the new behavior (if this is a feature change)?
In network area diagram viewer there is a functionality and a button to automatically resize the SVG in order to fit it in the window

Does this PR introduce a breaking change or deprecate an API?

  • Yes
  • No

If yes, please check if the following requirements are fulfilled

  • The Breaking Change or Deprecated label has been added
  • The migration steps are described in the following section

What changes might users need to make in their application due to this PR? (migration steps)
the constructor of the NetworkAreaDiagramViewer has an additional parameter: the flag for enabling the visualization of the button.
The demo/src/diagram-viewers/add-diagrams.js file has been changed for including this new parameter

Copy link

sonarqubecloud bot commented Feb 5, 2025

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant