Fix duplicate entries in ps_sync_state
#63
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
priority
column inps_sync_state
should have been a primary key to prevent duplicates (we're already usingINSERT OR REPLACE
when inserting).This bumps the schema version and re-creates the table when migrating, only keeping the most recent item in each priority from the old
ps_sync_state
table.I've also added tests asserting that:
sync_local
multiple times with a VFS mocking the current time inserts or updates rows inps_sync_state
as expected, and doesn't cause duplicate entries.