Skip to content

Revert ios framework #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Revert ios framework #44

merged 2 commits into from
Oct 21, 2024

Conversation

mugikhan
Copy link
Contributor

@mugikhan mugikhan commented Oct 21, 2024

Description

The framework bundle for powersync-sqlite-core.framework was causing a "Malformed Framework" error on macOS because it was missing the required symbolic links that are part of the standard framework structure. This was fixed in #41 however this change is not required for the iOS platforms and causes the distribution build (ipa/archive) to fail with an error.

Asset validation failed. Invalid bundle structure. The "Runner.app/Frameworks/powersync-sqlite-core.framework/Versions/A/powersync-sqlite-core" binary file is not permitted. 
Your app cannot contain standalone executables or libraries, other than a valid CFBundleExecutable of supported bundles. 
For details, visit: https://developer.apple.com/documentation/bundleresources/placing_content_in_a_bundle

Changes:

  • Revert back to standard structure for iOS frameworks
  • Bump versions

Directory Structure:
Screenshot 2024-10-21 at 16 28 49

@mugikhan mugikhan requested a review from rkistner October 21, 2024 14:31
@mugikhan mugikhan merged commit cd6f12e into main Oct 21, 2024
12 checks passed
@mugikhan mugikhan deleted the fix/revert-ios-framework branch October 21, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants