-
Notifications
You must be signed in to change notification settings - Fork 6
WASM builds #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
WASM builds #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2853b16
to
5d3c863
Compare
5d3c863
to
372d046
Compare
stevensJourney
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Manually added the builds to v0.3.0 release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a side-module WASM build. After lots of back and forth, it turns out the simplest way to get this working is to remove workarounds used before. This now builds the wasm file directly using rust - no custom emcc calls required.
For static build for sqlite3, this now uses a
staticlib
crate-type, producing libpowersync.a. This also removes the need of the workarounds used before with the .bc files, and can significantly simplify the sqlite3 build.See for more context on the dynamic lib: powersync-ja/wa-sqlite#16
Artifacts included in the release:
powersync.wasm
- synchronous side-module, emscripten-onlypowersync-async.wasm
asyncify side-module, emscripten-onlylibpowersync-wasm.a
(static lib, works for synchronous emscripten, asyncify empscripten and plain wasi builds)Example artifacts: