Conversation
🦋 Changeset detectedLatest commit: 53924bf The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ziahamza
changed the title
|
Hey @ziahamza, firstly thank you for putting in the effort and making this PR. In terms of an official release, we would prefer to wait for the stable Drizzle 1.0.0 version and then only support that instead of keeping support for 0.x.x versions, to make adoption and maintenance easier on our side. As an alternative, we could do dev releases off this PR and update it as changes from the upstream Drizzle project trickles down on the way to the v1 release. That would mean the work needed for this current PR includes a changeset entry, and potentially dropping all the backwards compatible code/documentation/tests you have added here. I suspect that might also simplify your implementation if you only had to worry about support v1 instead of backwards compatibility? |
Yes it will indeed simplify things a lot if we go all into v1 and drop backward compat support! Let me prepare the dev release with the correct change set to get the dev release out for projects already migrating to drizzle v1 beta |
ziahamza
force-pushed
the
drizzle-v1-beta
branch
from
ca5c9f9 to
9f4b337
Compare
| paragraphs | ||
| }; | ||
|
|
||
| export const drizzleRelations = defineRelations(drizzleSchema); |
There was a problem hiding this comment.
I think there's a 1-many relationship missing in this change.
| /** | ||
| * Nullify all nested objects from nullifyMap that are nullable | ||
| */ | ||
| function applyNullifyMap( |
There was a problem hiding this comment.
A lot of jdoc comments were removed in this file?
|
Hey @ziahamza. I have made a dev release for this drizzle package work under the following handle: I'll keep an eye on Drizzle releases in the near future, feel free to ping me here or on our Discord if you want to coordinate newer releases. Once again thanks a bunch for this work! |
2 participants
Summary
The PR adds support for Drizzle v1 beta relational queries through
relations+db.query, while keeping the existing0.44.xbehavior intact and exposingdb._queryas an alias on the0.44.xpath.