Performance improvement: don't need to re-compute bounding box for ev…

…ery object on every frame
povdocs · Aug 20, 2015 · c800afb · c800afb
1 parent e8d1ae0
commit c800afb
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/build/vr.dev.js b/build/vr.dev.js
diff --git a/build/vr.js b/build/vr.js
diff --git a/build/vr.js.map b/build/vr.js.map
diff --git a/src/vr-object.js b/src/vr-object.js
@@ -29,7 +29,6 @@ module.exports = (function () {
 			return scratchVector2.distanceTo(scratchVector1);
 		}
 
-		geometry.computeBoundingBox();
 		object.worldToLocal(scratchVector1);
 		return object.geometry.boundingBox.distanceToPoint(scratchVector1);
 	}
@@ -94,6 +93,10 @@ module.exports = (function () {
 			if (options.receiveShadow !== false) {
 				object.receiveShadow = true;
 			}
+
+			if (object.geometry) {
+				object.geometry.computeBoundingBox();
+			}
 		}
 
 		if (options.name !== undefined) {
@@ -103,7 +106,6 @@ module.exports = (function () {
 
 		if (allObjects.set) {
 			allObjects.set(object, this);
-			// allObjects.set(object.id, this);
 		} else {
 			allObjects[object.id] = this;
 		}