feat(helpers): add name property for output object #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijitkane
reviewed
Jul 22, 2019
|
|
||
| item.request = request; | ||
| // add name property, which postman will use to show in UI | ||
| item.name = request && request.url && request.url.path && request.url.path.join('/'); |
Member
There was a problem hiding this comment.
Thanks @valentinkononov 💯
Using _.get will be appropriate here
Also, can you add a regression test to the suite?
Author
There was a problem hiding this comment.
ok, will do later this week.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change adds name of item to output json, as result postman will show user friendly name in it's interface instead of just showing empty place