-
-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to use Font Awesome 6 #418
base: master
Are you sure you want to change the base?
Conversation
This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR. |
I've only quickly skimmed, but based on that the bot's comment seems unreasonable! Thanks for the PR, will look properly shortly. |
This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm certainly in favour of keeping the dependency up to date, but I'm not sure how I feel about bundling it rather than using a version published on CTAN.
Have you considered publishing yours?
This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR. |
I've never created or published a package on CTAN. I'm gonna try to do it and thus update my PR |
d0f8c03
to
4091a5a
Compare
This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR. |
4091a5a
to
67109bc
Compare
This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR. |
67109bc
to
c666410
Compare
This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR. |
Any luck with CTAN @xaviermawet? |
Hi @OJFord, I'll look into it very soon but with work and family, I haven't found the time to do it yet. |
Of course, no problem, just noticed you added some commits do wondered if you'd managed it. Cheers |
I planned on opening a pull request for this but then I realized there's already one opened. Why not just remove (or comment on) \RequirePackage{fontawesome} in awesome-cv.cls and add a new package in resume.tex using \usepackage{fontawesome5}? | Edit: Never mind. I just realized the font package is already Font Awesome 5 |
I uploaded a package named fontawesome6 on CTAN. I'm waiting for validation ! |
Oh great, nice one 🙂 |
@xaviermawet I can't find the package on CTAN |
@willb256 the package hasn't been validated yet. I'm currently discussing with one CTAN's validator and the authors of others fontawesome packages to synchronize us about the package naming vs fontawesome version, the macros collision with other fontawesome packages, etc... So my package isn't available yet because it didn't pass the validation phase right now. But it should be available soon. Stay tune ! |
🥺 |
c666410
to
0409176
Compare
This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR. |
0409176
to
1d17d21
Compare
This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR. |
This bot seems a bit annoying @posquit0, I'm not sure we get enough (genuine) PRs that we can't make that judgement 'manually' - any objection to turning it off? Or at least only running on PR creation, not every update (which can get very noisy as here). |
For now, I've excluded the binary files and the examples directory for |
1d17d21
to
901cf67
Compare
This PR has too many changes. Please make sure you are NOT addressing multiple issues with one PR. |
Hi,
This pull request adds latex commands for Font Awesome 6.1.1 free icons (inspired by #258 and #235).
Since there is no official FontAwesome6 package yet, I created a node application (latex-fontawesome) that consumes the Font Awesome GraphQL API to get icons metadata and generate definitions (
sty
file). Logic is based on plorcupine's latex-fontawesome project.Steps in order to use icons from so-generated
fontawesome6.sty
file:fontawesome6.sty
.