Skip to content

Remove requirejs as dependency #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 24, 2022
Merged

Remove requirejs as dependency #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e4194a5
Remove requirejs as dependency (shiny now includes it and provides a …
cpsievert May 12, 2022
936522d
Enable amd for the duration of requireLoader
cpsievert May 24, 2022
793e8cd
Use await instead of of then()
cpsievert May 24, 2022
816ae83
Require most recent version of shiny
cpsievert May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions ipyshiny/_dependencies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,6 @@
# TODO: scripts/static_download.R should produce/update these
def libembed_dependency() -> List[HTMLDependency]:
return [
# Load 3rd party widget dependencies at runtime via requirejs. One of the benefits of doing it
# this way is that for whatever reason, if we can't find the widgets statically assets locally,
# the requireLoader we use client side will fallback to loading the dependencies from a CDN.
HTMLDependency(
name="requirejs",
version="2.3.4",
source={"package": "ipyshiny", "subdir": "static"},
script={"src": "require.min.js"},
),
# Jupyter Notebook/Lab both come "preloaded" with several @jupyter-widgets packages
# (i.e., base, controls, output), all of which are bundled into this extension.js file
# provided by the widgetsnbextension package, which is a dependency of ipywidgets.
Expand Down
2 changes: 1 addition & 1 deletion ipyshiny/static/output.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading