Add preference for release channel #7534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a configurable release channel preference for Positron updates.
- Introduces a new nested configuration property "update.positron.channel" to allow selection of the update channel.
- Updates the relauncher and update service to observe and use the new "positron.channel" configuration.
- Removes the old UpdateChannel enum and adds a corresponding configuration contribution with limited enum options.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/workbench/contrib/relauncher/browser/relauncher.contribution.ts | Added a "positron" object with a "channel" property to the update configuration and registered it to trigger relaunch on change. |
| src/vs/platform/update/electron-main/abstractUpdateService.ts | Replaced the deprecated UpdateChannel enum with a dynamic configuration value for the update channel. |
| src/vs/platform/update/common/update.config.contribution.ts | Introduced a new configuration entry for "update.positron.channel" with specific allowed values and descriptions. |
|
E2E Tests 🚀 |
jmcphers
previously approved these changes
May 6, 2025
| @@ -93,7 +86,7 @@ export abstract class AbstractUpdateService implements IUpdateService { | |||
| */ | |||
| protected async initialize(): Promise<void> { | |||
| // --- Start Positron --- | |||
| const updateChannel = process.env.POSITRON_UPDATE_CHANNEL ?? UpdateChannel.Prereleases; | |||
| const updateChannel = process.env.POSITRON_UPDATE_CHANNEL ?? this.configurationService.getValue<string>('update.positron.channel'); | |||
There was a problem hiding this comment.
Would recommend emitting a log statement when we ignore the user-set value in favor of the environment variable.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #6489
Adds a preference for choosing where to get updates. The environment variable can still override the preference.
This allows users to switch to getting updates from the dailies.
Altering the preference will prompt the user to restart for the changes to take effect.
Release Notes
New Features
Bug Fixes
QA Notes