Data Explorer: Preserve non-file URIs when creating DuckDB clients #7533
+31
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
Previously we encoded only the original path in the data explorer, losing the scheme (and other URI attributes) and fundamentally assuming that we could only open local files. This commit instead encodes the original URI in its entirety and adds a helper to retrieve it, which makes it possible to use the `Open as Plain Text` button even with files backed by a virtual filesystem provider. Double-encoding the URI here is pretty gross, of course, but it's consistent with what we were already doing. This is the last piece of #7351. Signed-off-by: Aaron Jacobs <[email protected]>
atheriel
force-pushed
the
feature/aj-open-as-plain-text-preserve-uris
branch
from
cfe26f4 to
b653280
Compare
|
e2e issues seem to be resolved. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we encoded only the original path in the data explorer, losing the scheme (and other URI attributes) and fundamentally assuming that we could only open local files.
This commit instead encodes the original URI in its entirety and adds a helper to retrieve it, which makes it possible to use the
Open as Plain Textbutton even with files backed by a virtual filesystem provider.Double-encoding the URI here is pretty gross, of course, but it's consistent with what we were already doing.
This is the last piece of #7351.
e2e: @:data-explorer
Release Notes
New Features
Bug Fixes
QA Notes
We should ideally confirm that
Open as Plain Textworks when the data explorer is opened with a file backed by a virtual filesystem provider.