Skip to content

Hide Chat panel when Assistant is disabled #7519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jmcphers
Copy link
Collaborator

@jmcphers jmcphers commented May 2, 2025

This change hides the Chat panel entirely when Positron Assistant is disabled. The approach taken is:

  • Never show the Chat panel unless there are chat agents registered. The upstream configuration shows the panel in other contexts, such as when an incorrect version of Copilot is installed -- not something we need to worry about since we bundle Assistant.
  • Do not register any chat agents when Assistant is disabled. This is necessary since the default agent comes from a built-in extension and is therefore always registered.

Addresses #6828.

QA Notes

A reload or restart is required to apply the setting.

@jmcphers jmcphers requested a review from timtmok May 2, 2025 20:23
timtmok
timtmok previously approved these changes May 2, 2025
Copy link
Contributor

@timtmok timtmok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If the preference ever becomes user facing, it would be good to have a ChangeObserver on it to notify that a restart is required.

Copy link

github-actions bot commented May 2, 2025

E2E Tests 🚀
This PR will run tests tagged with: @:critical

readme  valid tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants