feat: support request body forwarding on redirects #390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
schloerke
reviewed
Feb 24, 2025
Co-authored-by: Barret Schloerke <[email protected]>
dbkegley
reviewed
Feb 27, 2025
|
|
||
|
|
||
| @responses.activate | ||
| def test_post_redirect_307(): |
There was a problem hiding this comment.
Do we need this test for 308 as well?
dbkegley
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All requests sent over HTTP to Connect are responded to with a redirect to the HTTPS location. By default,
Requestsfollows the default HTTP specification and removes the POST body when redirecting. We want to override this behavior to ensure the POST body is carried through the redirect.Resolves #385