Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: forward POST body with 3xx redirection statues #385

Open
tdstein opened this issue Feb 18, 2025 · 1 comment · May be fixed by #390
Open

feat: forward POST body with 3xx redirection statues #385

tdstein opened this issue Feb 18, 2025 · 1 comment · May be fixed by #390
Assignees
@tdstein
Labels
sdk Used for automation

Comments

@tdstein
Copy link
Collaborator

tdstein commented Feb 18, 2025

When accessing Connect insecurely (via HTTP), POSTs respond with 3xx error codes. By default, the original POST body is not forwarded on redirection. Other packages have handled this by overriding the default handler to forward the POST body on redirection.

See https://github.com/rstudio/rsconnect/blob/a3ebf70adb96a020fb8844b7194870ae04500a1d/R/http.R#L118-L120
@github-actions github-actions bot added the sdk Used for automation label Feb 18, 2025
@tdstein tdstein self-assigned this Feb 18, 2025
@nealrichardson
Copy link
Collaborator

I seem to remember there being a libcurl option about this, is it https://curl.se/libcurl/c/CURLOPT_POSTREDIR.html?

@tdstein tdstein linked a pull request Feb 24, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tdstein tdstein

Labels
sdk Used for automation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support request body forwarding on redirects posit-dev/posit-sdk-py
2 participants
@nealrichardson @tdstein