fix: remove unnecessary null check for oauth cred exchange #407
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Support ticket was raised: https://rstudioide.zendesk.com/agent/tickets/115510
There was an extra null check added in the sdk that is unnecessary since the connect endpoint handles this check in the latest version. By adding a default value here, version 0.7.0 breaks when trying to do a credential exchange with an older version of connect < 2025.03.0.
This check is not done in posit-sdk-py so this brings them into parity.
Approach
Removes the null check and default for the
requested_token_type
. So if the value is not set, a null value is passed through the api which will then determine which the proper default is in both older and newer versions of connect.Checklist
NEWS.md
(referencing the connected issue if necessary)?devtools::document()
?