-
Notifications
You must be signed in to change notification settings - Fork 14
Reticulate support #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reticulate support #506
Conversation
#' Used by the front-end to install reticulate | ||
#' A modal asking to install is shown before calling this. | ||
#' @export | ||
.ps.rpc.install_reticulate <- function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should that be .ps.rpc.install()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The frontend is able to set verbosity right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually shouldn't the frontend use the existing way of installing packages, i.e. r.packageInstall()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r.packageInstall
is essentially just devtools::install()
it doesn't allow installing arbitrary packages.
I can add .ps.rpc.install_package(pkg)
if we want a more general approach.
yes, the front-end can set verbosity
My main comment is about |
Co-authored-by: Lionel Henry <[email protected]>
bcb8bb7
to
f582e91
Compare
I addressed most points in 286a24a Also moved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG!
Add support for reticulate sessions. See posit-dev/positron#4603