Skip to content

Data Explorer: Add support for formatting options #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jun 12, 2024
Merged

Data Explorer: Add support for formatting options #382

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
fe32795
Move format_column to it's own file
dfalbel Jun 4, 2024
6294cd2
Move to an R implementation for formatting
dfalbel Jun 5, 2024
f665c8e
Adapt tests for new defaults
dfalbel Jun 5, 2024
a19b712
Add an R implementation matching Python tests
dfalbel Jun 5, 2024
16e9aff
Move to own formatter
dfalbel Jun 5, 2024
5198197
Support format options for the summary panel + refactor
dfalbel Jun 6, 2024
23ae211
typo
dfalbel Jun 7, 2024
21c5df9
Some small improvements
dfalbel Jun 7, 2024
f2de7b2
Improve comments in the `apply_thousands_separator` function
dfalbel Jun 11, 2024
f5a39fe
Apply suggestions from code review
dfalbel Jun 11, 2024
d5ec59b
`format_vec` -> `format_list`
dfalbel Jun 11, 2024
415ee07
Improve comments for `format_object`
dfalbel Jun 11, 2024
453b01b
Improve list formatting logic
dfalbel Jun 11, 2024
001d7ee
Move vectors constructors closer to type checks
dfalbel Jun 12, 2024
6f9bc7e
Use a global fallback format string.
dfalbel Jun 12, 2024
9d0847b
Don't clone as it's not needed.
dfalbel Jun 12, 2024
43fe996
Expose a more generic version and move assumptions closer to the R fu…
dfalbel Jun 12, 2024
1a04c34
Merge remote-tracking branch 'origin/main' into feature/formatting-op…
dfalbel Jun 12, 2024
fcbdaf5
Use `harp::list_get()`
dfalbel Jun 12, 2024
dcfb07f
Use if/else instead
dfalbel Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading