fix(history): use links in pinned history, fix dropdown position #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
derkoe
commented
Aug 5, 2020
•
derkoe
commented
- Pinned history should use default links (using href).
- History dropdown menu should have a configurable position with 'bottom-right' as the default
- Only display 3 entries of history
- Fix hideLast was of type "true"
|
@d-m-s this is how it looks now.
|
derkoe
force-pushed
the
fix/history-link-dropdown
branch
from
ee881ce to
86d8580
Compare
Wallabeng
requested changes
Aug 6, 2020
derkoe
force-pushed
the
fix/history-link-dropdown
branch
from
86d8580 to
d57ce85
Compare
Wallabeng
requested changes
Aug 6, 2020
derkoe
force-pushed
the
fix/history-link-dropdown
branch
from
d57ce85 to
1e573ce
Compare
derkoe
force-pushed
the
fix/history-link-dropdown
branch
from
1e573ce to
812fed8
Compare
- Pinned history should use default links (using href). - History dropdown menu should have a configurable position with 'bottom-right' as the default - Only display 3 entries of history - Fix hideLast was of type "true"
derkoe
force-pushed
the
fix/history-link-dropdown
branch
from
812fed8 to
f0b9c58
Compare
Wallabeng
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.