Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/enhance history component #860

Open
derkoe opened this issue Aug 5, 2020 · 0 comments
Open

Refactor/enhance history component #860

derkoe opened this issue Aug 5, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@derkoe
Copy link
Collaborator

derkoe commented Aug 5, 2020

There are different issues with the history component:

  • The component does not update when the history changes - should be refactored to use an Observable
  • The cookie reading/writing is quite complication and is done multiple time while changing the history - rewrite to have a single entry point.
  • initializeCookieSettings is called every time a component is used (history and pinned history)
  • Make max entries, cookie names, max age configurable
  • Username should not be outside of the context, it should be just another context property. Maybe event better: flatten the context to a single string - the using party can concat this themselves.
  • Handle links and iOS app mode correctly, when single history-items are located in different tlds due to modularisation.

Ensure that we keep the following design goal intact:

  1. we need to ensure proper link styling!
    valid "a href" seems to be required for clarity to apply styling.

  2. from ux-point of view we should enable the user to open a history-item in a new tab quickly
    ("CRTL+Click", "Left-Click > open in new Tab", ...)

  3. App-Mode must be supported and UX must not be brocken on mobile devices.
    this includes having different tld in history-items.

Nice to have:

  • if URL is in the current application's route then do not reload page but just open the route
@derkoe derkoe added the enhancement New feature or request label Aug 5, 2020
@derkoe derkoe added this to the 9.x milestone Aug 5, 2020
@d-m-s d-m-s added the help wanted Extra attention is needed label May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants