Support launching app in terminal #718
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wash2
requested changes
Nov 18, 2024
wash2
previously approved these changes
Nov 18, 2024
jackpot51
reviewed
Nov 18, 2024
src/desktop.rs
Outdated
| if !arg.starts_with('%') { | ||
| cmd.arg(arg); | ||
| let mut cmd = if terminal { | ||
| let mut cmd = std::process::Command::new("cosmic-term"); |
There was a problem hiding this comment.
What happens if cosmic-term is not installed?
There was a problem hiding this comment.
Good point. I'll try to come up with something. I see that cosmic-files handles this. And I assume the code for command + t also handles this but I haven't found that yet.
mmstick
force-pushed
the
master
branch
3 times, most recently
from
65f4422 to
2b7d171
Compare
jpttrssn
force-pushed
the
launch-app-in-term
branch
2 times, most recently
from
2b415c9 to
b450653
Compare
jpttrssn
force-pushed
the
launch-app-in-term
branch
from
b450653 to
97e501d
Compare
- Get terminal setting from desktop file - Launch app in terminal if set
- Add optional language sorter parameter to MimeAppCache::reload() - Use mime_app::exec_term_command in desktop::spawn_desktop_exec() - Add function mime_app::exec_term_to_command() to get exec command using terminal with fallback - Use this in MimeApp::command() - Use this in desktop::spawn_desktop_exec()
jpttrssn
force-pushed
the
launch-app-in-term
branch
from
97e501d to
55ad8f9
Compare
mmstick
reviewed
Jan 19, 2025
| [target.'cfg(unix)'.dependencies] | ||
| freedesktop-icons = { package = "cosmic-freedesktop-icons", git = "https://github.com/pop-os/freedesktop-icons" } | ||
| freedesktop-desktop-entry = { version = "0.5.1", optional = true } | ||
| freedesktop_entry_parser = "1.3" |
There was a problem hiding this comment.
Parsing of desktop entries is already provided by freedesktop-desktop-entry in the line above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports pop-os/cosmic-epoch#735
Requires: pop-os/cosmic-term#380