Add tracing similar to other cosmic apps#750
Open
laundmo wants to merge 1 commit intopop-os:masterfrom
Open
Conversation
This commit was made without any LLM generated code
jackpot51
reviewed
Feb 27, 2026
|
|
||
| let fmt_layer = fmt::layer().compact(); | ||
|
|
||
| match journald::layer() { |
Member
There was a problem hiding this comment.
It would be good to check if this is portable - what happens when trying to compile this on a non-systemd or non-linux OS?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to see if any logs show something about an issue i've been having, but it seems that this project never had logging set up in the first place.
I've looked at other cosmic projects and copied how they tend to set up logs. Specifically, i've taken the setup from cosmic-comp as it seems it doesn't require systemd as a feature flag while also not requiring it at runtime, tho i'm unsure about this.
I've tested it locally, and it seems to work both with
cargo runand running through the desktop file afterjust install