feat: Add new keyboard-bindable action: clear and reset.#742
Open
xward wants to merge 1 commit intopop-os:masterfrom
Open
feat: Add new keyboard-bindable action: clear and reset.#742xward wants to merge 1 commit intopop-os:masterfrom
xward wants to merge 1 commit intopop-os:masterfrom
Conversation
jackpot51
requested changes
Feb 20, 2026
Member
jackpot51
left a comment
jackpot51
left a comment
There was a problem hiding this comment.
The PR template is mandatory and must be filled in. It is not correct to inject reset into the input.
| // Reset the terminal by executing the reset command | ||
| // This fully reinitializes the terminal state (more thorough than clear) | ||
| // It clears the screen AND resets terminal settings, escape sequences, etc. | ||
| terminal.input_scroll(b"reset\n"); |
Member
There was a problem hiding this comment.
This is not the right way to reset. It just injects reset no matter what is running.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi !
Added QOL feature I miss from previous terminal in pop-os, a simple reset on terminal to flush everything. It looks like some other miss it too ! So here is my contribution.