implement open new tab in working dir#732
Open
wiiznokes wants to merge 1 commit intopop-os:masterfrom
Open
Conversation
|
Not a maintainer, but chipping in, because I want this. Having a setting that doesn't do anything: I really don't think this flies, would leave a really bad impression on these platforms ... except of course we don't care about those platforms, but then why bother at all? So my two cents: I think we need to hide the option, if it is not implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
continuation of #257
The cfgs are now in a dedicated file to not polute the codebase. But we still need them to support multiple os.
One problem is that the setting will be available on windows and macos, even tho the feature is not implemented. This will not cause a compile error tho, so ig it's ok. I could add a cfg in the ui code, but this will cause a warning, ect...
Lmk if the change looks good