fix: Align brightness reporting with cosmic-osd #1132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subhojeet-roy
changed the title
wash2
previously approved these changes
Nov 4, 2025
subhojeet-roy
force-pushed
the
fix/brightness-reporting-sync
branch
from
5962d48 to
89acf4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR to pop-os/cosmic-osd#148 and pop-os/cosmic-settings-daemon#113 to align brightness reporting calculation between cosmic-osd and cosmic-applet-battery slider.
This mismatch occurs in rare cases where the raw brightness scale for hardware is less than 20 units (as seen in System76 Darter Pro 8)