perf: use rustc-hash for HashMap and HashSet
#1113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Like with `cosmic-files`, this should be free performance as long as DOS attacks aren't a concern. `rustc-hash` is also already a transient dependency here, so this isn't building any more code.
|
Needs to be rebased due to a recent fix for bluetooth discovery overhead |
|
Done, I'm not too sure why Also looks like the lint is failing, I don't think that's this PR's fault |
mmstick
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically the same as pop-os/cosmic-files#1298, except no "benchmarks" this time (I don't think this will be as meaningful on performance, but it is basically free).