Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove sleep from it_should_run_connect_without_errors #7

Merged
merged 1 commit into from
Jun 16, 2024

Conversation

stutxo
Copy link
Contributor

@stutxo stutxo commented Jun 16, 2024

I was running the tests and it_should_run_connect_without_errors kept failing because the connect function wasn't finishing in time, so i had to add an extra sleep before the asserts.

   let _ = connect(
            "localhost:6680".to_string(),
            connect_manager_cloned,
            32,
            send_to_all_rx,
            Arc::new(Notify::new()),
        )
        .await;

        sleep(Duration::from_millis(100)).await;

        assert_eq!(listen_manager.num_connections(), 1);
        assert_eq!(connect_manager.num_connections(), 1);

Then i saw the comments that you want to remove the sleeps, so this my attempt at that.

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@pool2win
Copy link
Owner

Nice. Thanks for fixing this!

@pool2win pool2win merged commit a6ea56b into pool2win:main Jun 16, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants