Skip to content

Fix for #103 #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Dec 16, 2017
Merged

Fix for #103 #124

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8a8fdb4
test cases for #103
yiming-tang-cs Nov 30, 2017
36e9ed1
add on more test case #103
yiming-tang-cs Dec 1, 2017
fa7ddbb
fix #103
yiming-tang-cs Dec 4, 2017
55f2f71
#103 improve
yiming-tang-cs Dec 6, 2017
3443537
delete useless import
yiming-tang-cs Dec 6, 2017
ab87978
change method name and format
yiming-tang-cs Dec 6, 2017
05bf41a
#103 change iterator
yiming-tang-cs Dec 6, 2017
87bb0bc
#103 add a test case
yiming-tang-cs Dec 7, 2017
6ea3f22
add comments
yiming-tang-cs Dec 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ...r.streamrefactoring.tests/resources/ConvertStreamToParallel/testNonInternalAPI5/in/A.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
package p;

import java.util.HashSet;
import java.util.stream.*;

import edu.cuny.hunter.streamrefactoring.annotations.*;

class A {

Stream<Object> m() {
Stream<Object> stream = new HashSet<>().parallelStream().sorted();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fail to see how this is varying the execution order. Particularly, I should see a call to either parallel() or sequential() rather than something like sorted().

Copy link
Contributor Author

@yiming-tang-cs yiming-tang-cs Dec 1, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add one more test case similar to testNonInternalAPI4() but varying execution modes.

Is .parallelStream() not enough?
sorted() influences ordering and .parallelStream() influences execution mode. You want to see different execution mode or ordering?

return stream;
}

@EntryPoint
void n() {
Stream<Object> s = m();
s.distinct().count();
}
}
9 changes: 8 additions & 1 deletion ...es/edu/cuny/hunter/streamrefactoring/ui/tests/ConvertStreamToParallelRefactoringTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,14 @@ public void testNonInternalAPI4() throws Exception {
false, null, null, null, RefactoringStatus.ERROR,
EnumSet.of(PreconditionFailure.NO_TERMINAL_OPERATIONS)));
}


public void testNonInternalAPI5() throws Exception {
helper(new StreamAnalysisExpectedResult("new HashSet<>().parallelStream()",
Collections.singleton(ExecutionMode.PARALLEL), Collections.singleton(Ordering.UNORDERED), false,
false, false, null, null, null, RefactoringStatus.ERROR,
EnumSet.of(PreconditionFailure.NO_TERMINAL_OPERATIONS)));
}

public void testCollectionFromParameter() throws Exception {
helper(new StreamAnalysisExpectedResult("h.parallelStream()", Collections.singleton(ExecutionMode.PARALLEL),
Collections.singleton(Ordering.UNORDERED), false, true, false, null, null, null,
Expand Down