Open
Conversation
Author
|
It seems this has broken something when I check it locally, will try to investigate |
Author
|
Ok, I think i understand slightly more about context now. It shouldn't be possible to update the repetitions in |
Comment on lines
106
to
112
| let vs = if reserve-space and handout-mode.at(here()) { | ||
| (:) | ||
| } else { | ||
| visible-subslides | ||
| } | ||
| repetitions.update(rep => calc.max(rep, _last-required-subslide(vs))) | ||
| if _check-visible(subslide.at(here()).first(), vs) { | ||
| repetitions.update(rep => calc.max(rep, _last-required-subslide(visible-subslides))) | ||
| if in-subslide(vs) { |
Collaborator
There was a problem hiding this comment.
You are now ignoring the handout mode case. We need to use vs instead of visible-subslides.
Author
There was a problem hiding this comment.
Good catch, this must have seeped in as I was trying to move things between this function and in-subslide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #228.
Adds an
in-subslidefunction as discussed in #228 for programmatically checking whether you are in a certain subslide. Also refactors_conditional_displayto use this function.I wasn't sure if there's a test suite I can run to check this doesn't break anything, or if I need to update documentation somewhere, but happy to do this if pointed in the right direction.