Skip to content

Format typst files and require correct formatting of PRs#205

Open
rmburg wants to merge 6 commits intopolylux-typ:mainfrom
rmburg:fmt
Open

Format typst files and require correct formatting of PRs#205
rmburg wants to merge 6 commits intopolylux-typ:mainfrom
rmburg:fmt

Conversation

@rmburg
Copy link
Contributor

@rmburg rmburg commented Feb 3, 2025

See this test PR on my fork to see how the CI check would look. I'm open to change how this works, let me know what you think.

Maybe I should also document the use of Typstyle somewhere.

@andreasKroepelin
Copy link
Collaborator

There is a problem with formatting the book examples.

  1. The code snippets are included in the book based on a line interval. These line numbers in the .md files would have to be adapted.
  2. Often, the code is not indented on purpose because it would look strange in the book without the outer code.

@rmburg rmburg force-pushed the fmt branch 2 times, most recently from d453505 to 965095b Compare October 9, 2025 12:23
@rmburg rmburg force-pushed the fmt branch 2 times, most recently from 6d98975 to 9ea8db8 Compare October 10, 2025 10:08
@rmburg
Copy link
Contributor Author

rmburg commented Oct 10, 2025

Apologies for the delay. I've updated the PR with your suggestions.
The leading whitespace issue in mdbook seems to be known: rust-lang/mdBook#1430
For now, I've excluded book/ from the checks.
Once the issue is fixed, we can update the checks to include the book as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants