Skip to content

[WIP] Adding documentation for @polybase/client #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

timmyjose
Copy link
Contributor

@timmyjose timmyjose commented Aug 22, 2023

Changes:

  • added minimal support for TSDoc (typedoc).

Limitations (due to typedoc):

  • Only the exported entities appear as is in the documentation. Non-exported types are segregated into an <internal> section per module, but private functions are not listed.
  • The layout is flat - the modules all appear in the navigation panel instead of a single entrypoint module, in the documentation.

  - added minimal support for TSDoc
@linear
Copy link

linear bot commented Aug 22, 2023

ENG-995 Add documentation for `polybase-ts/client`.

Creating separate issue since polybase-ts has many subprojects, and adding documentation for each project can be better done piecemeal.

@timmyjose
Copy link
Contributor Author

timmyjose commented Aug 22, 2023

This is a WIP PR for tracking documentation for @polybase/client. Working on the default HTML documentation first. If desired, Markdown output can be generated using the typedoc-plugin-markdown plugin.

@timmyjose timmyjose changed the title [WIp] Adding documentatioon for @polybase/client [WIP] Adding documentatioon for @polybase/client Aug 22, 2023
@timmyjose timmyjose changed the title [WIP] Adding documentatioon for @polybase/client [WIP] Adding documentation for @polybase/client Aug 22, 2023
  - added a new plugin to export non-exported (but referenced) types
    (typedoc-plugin-missing-exports)
  - Added basic documentation for `Polybase` and `Client` types.
  - added documentation to functions in `util.ts`.
  - added documentation for `Record`.
  - using tenses consistently.
  - added some links to the official docs in Collection.
@timmyjose timmyjose requested a review from calummoore August 23, 2023 07:13
@timmyjose
Copy link
Contributor Author

How to generate the docs locally:

  $ npm install (or yarn install)

and then

  $ npm run doc (or yarn run doc)

The documentation is generated in a doc directory at the project root. Then we can open it in the browser (for example, on macOS or similar):

  $ open doc/index.html

@timmyjose
Copy link
Contributor Author

Update: working on a uniform way of updating docs across all projects in polybase-ts conforming to the doc repo's mintlify-based documentation scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant