More sale details + region info #11188
Open
+729
−320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt region dates on the sale overview, links to other coretime resellers
piggydoughnut
changed the title
TarikGul
reviewed
Jan 17, 2025
| name: 'Interlude/Renewals phase' | ||
| }, | ||
| [PhaseName.PriceDiscovery]: { | ||
| description: 'The period during which cores are available for both purchase and renewal. The price is linearly declining price.', |
There was a problem hiding this comment.
IMO The price is linearly declining price. sounds a bit off - maybe something like: The price decreases linearly over time.
TarikGul
reviewed
Jan 17, 2025
| name: 'Price Discovery phase' | ||
| }, | ||
| [PhaseName.FixedPrice]: { | ||
| description: 'The period during which cores are available for both purchase and renewal. The price is fixed price towards the end of the sales period.', |
There was a problem hiding this comment.
Suggested change
| description: 'The period during which cores are available for both purchase and renewal. The price is fixed price towards the end of the sales period.', | |
| description: 'The period during which cores are available for both purchase and renewal. The price is a fixed price towards the end of the sales period.', |
TarikGul
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added:
This tab is useful for people who need numbers connected to sales, when each phase started/finished, which dates, blocks, etc.
Resolves #11182