Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fellowship Salary Budget & Period #121

Merged
merged 5 commits into from
Jan 8, 2024
Merged

Fellowship Salary Budget & Period #121

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f7e16a2
fellowship salary budget
muharem Dec 11, 2023
b0cdbde
Merge branch 'main' into muharem-fellowship-sallary-settings
bkchr Dec 13, 2023
6ddd7ee
changelog
muharem Jan 2, 2024
a6e0fad
Merge branch 'main' into muharem-fellowship-sallary-settings
ggwpez Jan 4, 2024
464fd23
Merge branch 'main' into muharem-fellowship-sallary-settings
bkchr Jan 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion system-parachains/collectives/collectives-polkadot/src/fellowship/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,7 @@ impl pallet_salary::Config<FellowshipSalaryInstance> for Runtime {
// 15 days to claim the salary payment.
type PayoutPeriod = ConstU32<{ 15 * DAYS }>;
// Total monthly salary budget.
type Budget = ConstU128<{ 100_000 * USDT_UNITS }>;
type Budget = ConstU128<{ 250_000 * USDT_UNITS }>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we will want to make this number configurable, as obviously we need to adjust the budget every once a while. This will be a good candidate to integrate with parameters pallet, whatever it is the one in ORML, or polkadot-sdk

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we want very very quick win for this release:

parameter_types! {
     pub storage Budget: u128 = 250_000 * USDT_UNITS`;
}

type Budget = Budget

and allow it for SafeCallFilter here

                // Allow to change dedicated storage items (called by governance-like)
		match call {
			RuntimeCall::System(frame_system::Call::set_storage { items })
				if items.iter().all(|(k, _)| k.eq(&Budget::key()))) => return true,
			_ => (),
		};

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer just do the correct way. the storage parameters is not in metadata and hard to work with in frontend

}

parameter_types! {
Expand Down