You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main reason for the upgrade is to try to resolve the memory leak issue in polkadot-sdkstable2409, but this PR has not been backported to stable2409.
The reason will be displayed to describe this comment to others. Learn more.
I leave comments on parts where Deref is not necessarily required. As for the SelfContained, I haven’t been able to review it in depth yet, but I will take the time to revisit it.
I am struggling with integration testing and I estimate it will take me some time to complete the work.
Spent sometime yday looking at the changes, seems like all the failing tests are due to InvalidParams error from RPC from what I see. I suppose something changes in the rlp or evm versions that got bumped @0xbillw
I started receiving similar errors after updating to 2409 and have been experiencing issues after updating to 2412. Invalid Param when retrieving the receipt, hanging transactions... Overall, it works, but about 10% of the tests fail unpredictably
I leave comments on parts where Deref is not necessarily required. As for the SelfContained, I haven’t been able to review it in depth yet, but I will take the time to revisit it. @conr2d Thank you for your review and guidance; I have made all the necessary changes.
Hi, I just would like to ask: when can this PR be merged? I am one of the users waiting for a new stable2412 release branch. It will be really appreciated. 👍
I noticed a few issues in the changes on fp-self-contained. It would be better to address these before merging the PR. I'll provide a detailed review tomorrow.
@0xbillw No critical issues are found. Please refer to conr2d/frontier@df360d6 for removing non-essential trait bounds from fp-self-contained. For transaction pool, it might be better to address it in a separated PR.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0xbillw
force-pushed
the
stable2412
branch
2 times, most recently
from
The main reason for the upgrade is to try to resolve the memory leak issue in
polkadot-sdkstable2409, but this PR has not been backported tostable2409.