fix build issue on Mac Catalyst #485
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samulimaa
force-pushed
the
master
branch
2 times, most recently
from
0ade256 to
7c821ca
Compare
zwift-aebling
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When compiling the iOS SDK as part of a Mac Catalyst app, the selector
int32Valueis ambiguous, because it's defined both byNSNumberas well asNSAppleEventDescriptor(which isn't available on iOS, hence why everything works fine when compiling for that).This PR fixes this issue, thereby adding the ability for Mac Catalyst applications to use the SDK and connect to polar devices.
(We know that the
NSNumbercast is fine, bc we only ever addNSNumberinstances to the array...)