-
Notifications
You must be signed in to change notification settings - Fork 65
feat/default-instance-circuitbreaker #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/default-instance-circuitbreaker #256
Conversation
96b77da to
58b0c64
Compare
| // GetErrorRateConfig 错误率熔断配置 | ||
| // Deprecated: 不在使用 | ||
| GetErrorRateConfig() ErrorRateConfig | ||
| IsDefaultRuleEnable() bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
是否需要添加注释?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
加了,再看下
| func (c *CompositeCircuitBreaker) doSchedule(expectKey model.ServiceEventKey) { | ||
| c.log.Debugf("[CircuitBreaker] doSchedule started, namespace: %s, service: %s, eventType: %v", | ||
| expectKey.Namespace, expectKey.Service, expectKey.Type) | ||
| scheduledCount := 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scheduledCount做啥的?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
就是debug的时候用到了打日志记录这个函数执行了几次,之前排查问题打了一些日志,我把它去掉吧,忘记删了
SkyeBeFreeman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Please provide issue(s) of this PR:
Fixes #247
To help us figure out who should review this PR, please put an X in all the areas that this PR affects.
Please check any characteristics that apply to this pull request.