Skip to content

Conversation

@peerless1024
Copy link
Member

Please provide issue(s) of this PR:
Fixes #247

To help us figure out who should review this PR, please put an X in all the areas that this PR affects.

  • Configuration
  • Docs
  • Performance and Scalability
  • Naming
  • HealthCheck
  • Test and Release

Please check any characteristics that apply to this pull request.

  • Does not have any user-facing changes. This may include API changes, behavior changes, performance improvements, etc.

@peerless1024 peerless1024 force-pushed the feat/default-instance-circuitbreaker branch from 96b77da to 58b0c64 Compare December 3, 2025 07:35
// GetErrorRateConfig 错误率熔断配置
// Deprecated: 不在使用
GetErrorRateConfig() ErrorRateConfig
IsDefaultRuleEnable() bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是否需要添加注释?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

加了,再看下

func (c *CompositeCircuitBreaker) doSchedule(expectKey model.ServiceEventKey) {
c.log.Debugf("[CircuitBreaker] doSchedule started, namespace: %s, service: %s, eventType: %v",
expectKey.Namespace, expectKey.Service, expectKey.Type)
scheduledCount := 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scheduledCount做啥的?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

就是debug的时候用到了打日志记录这个函数执行了几次,之前排查问题打了一些日志,我把它去掉吧,忘记删了

Copy link
Member

@SkyeBeFreeman SkyeBeFreeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peerless1024 peerless1024 merged commit 40517f5 into polarismesh:main Dec 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

实例级熔断支持开启默认规则

2 participants