Skip to content

feat(installation): support cross-compiling the R package via the --host option of the configure script #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

eitsupi
Copy link
Collaborator

@eitsupi eitsupi commented Jan 9, 2024

Same as PRQL/prqlc-r#247

R-universe started distributing R binary packages for arm64 macOS yesterday (r-universe-org/help#340).

image

This PR should enable both of the following two R package cross-compilation methods to work.

  1. Compile from Rust source (confirmed with feat(installation): support cross-compiling the R package via the --host option of the configure script PRQL/prqlc-r#247)
  2. Download and use Rust binary libraries from the internet (Checked on my R-universe eitsupi/eitsupi.r-universe.dev@2b5163f)

@eitsupi
Copy link
Collaborator Author

eitsupi commented Jan 9, 2024

It seems working. (ecae98c)

image

@eitsupi eitsupi marked this pull request as ready for review January 9, 2024 12:50
Copy link
Collaborator

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No clue about this, so just go ahead ;)

@eitsupi
Copy link
Collaborator Author

eitsupi commented Jan 9, 2024

Thanks for looking at this, I would like to create a new release immediately after merging this to update the R-universe binaries.

@eitsupi eitsupi changed the title feat(installation): support cross-compiling the R package via the --build option of the configure script feat(installation): support cross-compiling the R package via the --host option of the configure script Jan 9, 2024
@eitsupi eitsupi merged commit 5165090 into main Jan 9, 2024
@eitsupi eitsupi deleted the support-cross-compile branch January 9, 2024 13:07
@etiennebacher
Copy link
Collaborator

Ok for the release (can you bump news?)

Actions failing due to github: githubstatus.com

@eitsupi eitsupi mentioned this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants