-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TRT-571 - Update net2cog to process multiple variables. #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
owenlittlejohns
commented
Feb 3, 2025
frankinspace
reviewed
Feb 3, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thank you for the contribution! Just a few comments to consider
frankinspace
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue: #32 (also one of the items mentioned in #35).
Description
This PR adds support for requests asking for multiple variables, either explicitly, or when a Harmony request specifies "all".
Overview of work done
There's a fair bit of shuffling around, but essentially the code changes are:
_write_cogtiff
function has been rescoped to just write a single COG. The iteration now takes place innetcdf_converter
.generate_output_filename
from theharmony-service-lib-py
module, which now has areformatted
suffix (note, this is a minor difference fromconverted
). I removed a bunch of custom code that was geared around generating the output filename, as that is no longer needed.conftest.py
.Overview of verification done
tests/conftest.py
). There are now tests that run to confirm multiple variables can be processed, either via explicitly requesting them or by using "all" in a Harmony request. These tests exist at the overall service level, and thenetcdf_converter
function level.Overview of integration done
PR checklist:
See Pull Request Review Checklist for pointers on reviewing this pull request