feat(page-job-scheduler): permite configuração de frequência #1102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ao selecionar a periodicidade mensal e não selecionar a frequência(primeira etapa de agendamento), está retornando "undefined" na informação da execução(ultima etapa de conclusão).
|
alinelariguet
force-pushed
the
job-scheduler/DTHFUI-5526
branch
from
4cf02e3 to
a80ee07
Compare
jcorrea97
reviewed
Nov 19, 2021
|
|
||
| spyOn(component['poPageJobSchedulerService'], 'convertToJobSchedulerInternal').and.returnValue(returnValue); | ||
| component.value = jobSchedulerInternal; | ||
| // expect(component.model instanceof PoPageJobSchedulerInternal).toBeTruthy(); |
| expect(result).toBe(expectedValue); | ||
| }); | ||
|
|
||
| it('getFrequencyValue: should return `frequency[value] - frequency[type]`', () => { |
There was a problem hiding this comment.
descrição do teste igual ao anterior
| expect(value).toEqual(valueExpected); | ||
| }); | ||
|
|
||
| it('removeInvalidKeys: should remove invalid keys if keys is `rangeExecutions` and periodicity is `single`', () => { |
There was a problem hiding this comment.
descrição do teste igual ao anterior
Permite configuração da frequência no componente PoPageJobScheduler. Fixes DTHFUI-5526
alinelariguet
force-pushed
the
job-scheduler/DTHFUI-5526
branch
from
6f46ab5 to
33e1153
Compare
jcorrea97
approved these changes
Nov 19, 2021
brunoromeiro
approved these changes
Nov 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PAGE JOB SCHEDULER
DTHFUI-5526
PR Checklist [Revisor]
Qual o comportamento atual?
Não é possível configurar a frequência
Qual o novo comportamento?
Permite configurar a frequência
Simulação
Simular através do sample do portal.
app 2.zip
PR no po-sample-api - WIP