feat(coord): §1e chore-claim gate with proactive queue enrichment#886
feat(coord): §1e chore-claim gate with proactive queue enrichment#886otherness-app[bot] wants to merge 3 commits into
Conversation
…fer gaps Vibe-vision autonomous scan (Step A). No human input required. Changes: 2 files changed, 5 insertions(+) Scans performed: - Scan 1: promote shipped 🔲 Future → ✅ Present (matched against merged PRs) — 0 promoted - Scan 2: flag stale ✅ Present items (referenced files missing) — 0 stale - Scan 3: infer 🔲 Future items from untracked TODO/FIXME in code — 0 added - Scan 4: deprecate 🔲 Future items stale >90 days with no open issue — 0 deprecated - Scan 5: self-updating pressure prompts — 0/5 bullets addressed (pressure still active) New 🔲 Future items added from pressure-context gap analysis: - 32.W1: Interactive wizard-style onboarding (/otherness.setup --wizard) — onboarding lens - 39.27: Automated weekly digest of report issue comments — visibility lens Signed-off-by: otherness[bot] <otherness[bot]@users.noreply.github.com>
When MEANINGFUL_PRS_THIS_SESSION==0 and COORD would claim a kind/chore item, §1e-chore-gate intercepts: scans docs/design/*.md for an unissued 🔲 Future item, creates a GitHub issue for it, and claims that instead. This converts the minimum meaningful-PR guarantee from post-hoc detection (SM §4b DEFECT) to proactive enforcement at claim time. Fallback: if no unissued Future items exist, writes meaningful_pr_guarantee_failed=true to state.json and claims the chore. Fail-open on any error. Design doc updated: docs/design/21-session-throughput.md (🔲 → ✅) Signed-off-by: otherness[bot] <otherness[bot]@users.noreply.github.com> 🤖 Generated with [Claude Code](https://claude.ai/code)
|
[NEEDS HUMAN: critical-tier-change] This PR modifies agents/phases/coord.md (CRITICAL tier). Deploys to all projects on next session startup. Requires human review before merge. |
QA WRONG finding: the previous is_chore logic had false positives for items with no kind/ labels (area-only labels incorrectly flagged as chore). New logic: is_chore = True only when ALL kind/ labels are 'kind/chore' or 'kind/docs' AND at least one kind/ label exists. Items with no kind/ label are treated as non-chore (fail-open). Signed-off-by: otherness[bot] <otherness[bot]@users.noreply.github.com> 🤖 Generated with [Claude Code](https://claude.ai/code)
|
[AGENT SELF-REVIEW | sess-7af2b350 | otherness@103578b] 5-check CRITICAL-A self-review:
Result: All 5 checks pass. |
|
[🔄 SDM §4a | sess-f95ca388] PR #886 (feat(coord): §1e chore-claim gate) has |
Summary
§1e-chore-gatetocoord.md: whenMEANINGFUL_PRS_THIS_SESSION==0and COORD would claim akind/choreitem, the gate intercepts and injects a feature item firstdocs/design/*.mdfor an unissued🔲 Futureitem, creates a GitHub issue, and claims it insteadmeaningful_pr_guarantee_failed: truetostate.jsonso SM §4b can diagnoseMEANINGFUL_PRS_THIS_SESSIONshell variable initialized at§1astartup and exported for ENG/QA to incrementMotivation
The session minimum meaningful-PR contract (design doc 35.x, issue-796) fires a
[DEFECT]after the session ends with 0 meaningful PRs. This is retrospective. This PR makes the guarantee proactive: COORD cannot ship only chores unless there are literally no non-chore items available to generate from design docs.Risk assessment
CRITICAL tier — modifies
agents/phases/coord.md. Deploys to all projects on next session start.PASS {ITEM_ID}→ normal claimREPLACE/PASSoutput parsingCloses #882
Design doc
Updated
docs/design/21-session-throughput.md: moved §1e chore-claim gate item from 🔲 Future to ✅ Present.[NEEDS HUMAN: critical-tier-change]
Signed-off-by: otherness[bot] <otherness[bot]@users.noreply.github.com>