Skip to content

Conversation

@Adam-it
Copy link
Member

@Adam-it Adam-it commented Nov 2, 2025

🎯 Aim

The aim of this PR is to update the astro npm package which will also update the sub dependencies and solve all security issues we have in this repo.
As astro had an update to the way the images are handled, we also agreed to move all images to /dcos subcatalog

🧪 How and what to test

We should check if images from new location render correctly so I suggest checking the following:

  • build and start the docs locally and recheck all pages if all images are shown
  • check images in extension by doing the following
    • if you have, uninstall SPFx Toolkit
    • build SPFx Toolkit vscode package locally by runing vsce package
    • install SPFx Toolkit from local file
    • recheck walkthrough
    • recheck readme by showing the extension from the VS Code marketplace inside VS Code - ⚠️ This is a bit tricky as the readme takes images directly from repo so since this is not merged yet those will not render. BUT what we may do is open the vscode webview developer tools and manually check the paths (URLS) of each images in the readme and if it is taken from the new location

✅ What was done

  • updated astro npm package
  • moved all images to /docs/assets/images-vscode
  • updated all paths in docs
  • updated all paths in package.json, readme, walkthrough
  • excluded /docs/assets/images-vscode from .vscodeignore file

🔗 Related issue

Closes: #616

@Adam-it Adam-it linked an issue Nov 2, 2025 that may be closed by this pull request
2 tasks
@Adam-it Adam-it changed the title Updates astro package and moves images to different location Updates astro package and moves images to different location. Closes #616 Nov 2, 2025
@Adam-it Adam-it marked this pull request as ready for review November 2, 2025 22:26
@Saurabh7019 Saurabh7019 self-assigned this Nov 4, 2025
@Saurabh7019 Saurabh7019 merged commit e9d9eac into pnp:main Nov 6, 2025
1 check passed
@Saurabh7019
Copy link
Collaborator

This is merged! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve dependabot issues

2 participants