Refactor the way we add CLI for Microsoft 365 to SPFx Toolkit. Closes #526 #629
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Aim
The aim is to refactor SPFx Toolkit to use our own version of CLI for Microsoft 365 npm package instead of the hacky current approach. As a result, I published our own version of CLI for Microsoft 365 for SPFx Toolkit (https://www.npmjs.com/package/@pnp/cli-microsoft365-spfx-toolkit) in CommonJS, and now SPFx Toolkit simply uses this package instead of doing it manually. This simplified development also allows us to have a more formal version of CLI for Microsoft 365 that is based on the official package but has some tweaks created for this project
🧪 Ideas to test
I would suggest to run
npm installandvsce packageto create the local version of the extension locally and install it in VS Code and click around the SPFx Toolkit mainly focusing on features that use CLI for Microsoft 365 commands.✅ What was done
🔗 Related issue
Closes: #526