Skip to content

Conversation

@Adam-it
Copy link
Member

@Adam-it Adam-it commented Nov 2, 2025

🎯 Aim

The aim is to refactor SPFx Toolkit to use our own version of CLI for Microsoft 365 npm package instead of the hacky current approach. As a result, I published our own version of CLI for Microsoft 365 for SPFx Toolkit (https://www.npmjs.com/package/@pnp/cli-microsoft365-spfx-toolkit) in CommonJS, and now SPFx Toolkit simply uses this package instead of doing it manually. This simplified development also allows us to have a more formal version of CLI for Microsoft 365 that is based on the official package but has some tweaks created for this project

🧪 Ideas to test

I would suggest to run npm install and vsce package to create the local version of the extension locally and install it in VS Code and click around the SPFx Toolkit mainly focusing on features that use CLI for Microsoft 365 commands.

✅ What was done

  • Updated npm package.json to use CLI for Microsoft 365 SPFx Toolkit package and updated all imports
  • deleted the hacky script to ingest CLI for Microsoft 365 from the local repo build
  • cleaned up contributing guidance
  • cleaned up GitHub Workflows not to build CLI for Microsoft 365 repo and added the files manually

🔗 Related issue

Closes: #526

@Adam-it Adam-it linked an issue Nov 2, 2025 that may be closed by this pull request
@Adam-it
Copy link
Member Author

Adam-it commented Nov 2, 2025

ok one point I missed is that we should get rid of fsevents before we proceed

@Adam-it Adam-it marked this pull request as draft November 2, 2025 00:42
@Adam-it
Copy link
Member Author

Adam-it commented Nov 2, 2025

Setting this to draft until I solve the fsevents issue

@Adam-it Adam-it force-pushed the refactor-how-we-add-cli-2 branch from b3a30f8 to c210771 Compare November 2, 2025 20:28
@Adam-it Adam-it marked this pull request as ready for review November 2, 2025 20:29
@Adam-it
Copy link
Member Author

Adam-it commented Nov 2, 2025

Ready for review 🤩

@nicodecleyre nicodecleyre self-assigned this Nov 3, 2025
@nicodecleyre
Copy link
Collaborator

Thank you for your PR 👏👏👏 ! We'll review is ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update the way we include CLI for Microsoft 365 in our project

2 participants